fix: invalid resolution of icon-helpers #16823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tay1orjones
commented
Jun 19, 2024
| @@ -1921,7 +1914,7 @@ __metadata: | |||
| languageName: unknown | |||
| linkType: soft | |||
|
|
|||
| "@carbon/icon-helpers@npm:^10.28.0, @carbon/icon-helpers@npm:^10.49.0, @carbon/icon-helpers@workspace:packages/icon-helpers": | |||
There was a problem hiding this comment.
This is the source of the invalid resolution: @carbon/icon-helpers@npm:^10.28.0
guidari
previously approved these changes
Jun 19, 2024
tay1orjones
commented
Jun 19, 2024
| @@ -1921,7 +1914,7 @@ __metadata: | |||
| languageName: unknown | |||
| linkType: soft | |||
|
|
|||
| "@carbon/icon-helpers@npm:^10.28.0, @carbon/icon-helpers@npm:^10.49.0, @carbon/icon-helpers@workspace:packages/icon-helpers": | |||
| "@carbon/icon-helpers@npm:^10.49.0, @carbon/icon-helpers@workspace:packages/icon-helpers": | |||
There was a problem hiding this comment.
Fixed here after removing the example from the workspaces
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Jun 19, 2024
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Jun 19, 2024
* fix: invalid resolution of icon-helpers * fix: relocate the incremental-migration-vite example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent v11.60.0 release failed because of an invalid resolution of
@carbon/icon-helpers(logs). Theincremental-migration-viteexample relies on[email protected], which relies on an older version of@carbon/icons-reactthan what we use in the rest of the monorepo. We couldn't resolve this viadedupeorhoistingLimits(the previous fix, #14481).The solution we landed on here is to remove the
incremental-migration-viteexample from the repo to being a standalone stackblitz link. We've updated the readme to point to the link.Changelog
Changed
incremental-migration-viteproject filesincremental-migration-vitereadme.md to link to the new stackblitz exampleTesting / Reviewing
v11.60.1